Skip to content

🐛 do not set tags on existing network interfaces when creating ec2 instances #5595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 do not set tags on existing network interfaces when creating ec2 instances #5595

wants to merge 1 commit into from
+6 −1

Conversation

kylewuolle
Copy link

/kind bug

What this PR does / why we need it:
When creating an ec2 instance the awsmachine_controller tags existing network interfaces which leads to the creation of ec2 instances failing with the error : InvalidParameterValue: You cannot specify tags for network interfaces if there are no network interfaces being created by the request.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5594

Checklist:

  • [x ] squashed commits
  • includes documentation
  • [x ] includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Fix issue with creation of ec2 instances when specifying an existing network interface

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from Ankitasw July 17, 2025 17:04
@k8s-ci-robot
Copy link
Contributor

Welcome @kylewuolle!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from damdo July 17, 2025 17:04
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kylewuolle. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2025
@kylewuolle kylewuolle mentioned this pull request Jul 17, 2025
Open
@kylewuolle kylewuolle changed the title fix: 🐛do not set tags on existing network interfaces when creating ec2 instances 🐛 do not set tags on existing network interfaces when creating ec2 instances Jul 17, 2025
@damdo
Copy link
Member

damdo commented Jul 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2025
@damdo
Copy link
Member

damdo commented Jul 18, 2025

/assign @nrb @richardcase @AndiDog @dlipovetsky

@kylewuolle kylewuolle mentioned this pull request Jul 7, 2025
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2025
@nrb
Copy link
Contributor

nrb commented Jul 29, 2025

@kylewuolle Thanks for this! It looks fine to merge to me, just need to rebase it.

@kylewuolle kylewuolle force-pushed the fix-existing-network-interface branch from d8eb919 to ba7b934 Compare August 6, 2025 23:23
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andidog. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2025
@kylewuolle
Copy link
Author

kylewuolle commented Aug 6, 2025 •
edited
Loading

@kylewuolle Thanks for this! It looks fine to merge to me, just need to rebase it.

@nrb Done thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@damdo damdo Awaiting requested review from damdo

Assignees

@richardcase richardcase

@nrb nrb

@AndiDog AndiDog

@dlipovetsky dlipovetsky

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EC2 instance creation fails when specifying an existing network interface
7 participants
@kylewuolle @k8s-ci-robot @damdo @nrb @richardcase @AndiDog @dlipovetsky